ref(replays/issues): update replay inline onboarding panel to use prompt dismiss #69525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
reviewed
Apr 23, 2024
static/app/components/events/eventReplay/replayInlineOnboardingPanel.spec.tsx
Outdated
Show resolved
Hide resolved
michellewzhang
force-pushed
the
mz/prompt-dismiss
branch
2 times, most recently
from
d6a7c18 to
d1ef0bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69525 +/- ##
==========================================
- Coverage 79.64% 79.64% -0.01%
==========================================
Files 6479 6481 +2
Lines 287655 287694 +39
Branches 49580 49590 +10
==========================================
+ Hits 229110 229135 +25
- Misses 58108 58188 +80
+ Partials 437 371 -66
|
michellewzhang
force-pushed
the
mz/prompt-dismiss
branch
from
d1ef0bb to
71095e6
Compare
c298lee
approved these changes
Apr 24, 2024
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
…mpt dismiss (#69525) - followup from #69513 - closes #69207 - update the issue details replay inline onboarding CTA to use prompt dismiss instead of `useDismissAlert` - behavior should still be the same: snooze is 7 days, dismiss is forever - also made some updates to `usePrompt` hook to allow for snoozing 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useDismissAlertusePrompthook to allow for snoozing